LLDP: Fix issue with restart_orchagent as VOQ does not support warm restarting of orchagent (#16765)#218
Merged
arlakshm merged 1 commit intoAzure:202503from May 8, 2025
Merged
Conversation
…estarting of orchagent (#16765) Description of PR test_lldp_neighbor_post_orchagent_reboot uses prefix restart_orchagent() to warm restart orchagent. This warm restart of orchagent(kill orchagent and restart orchagent process) is not supported on chassis with type VOQ. Add code to handle chassis type VOQ case by restarting the swss@0(1) service. This will cause ports to be removed from lldp table and add back in so we can test the issue found in #6560. Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? Currently test_lldp_neighbor_post_orchagent_reboot is failing against chassis with type VOQ. It's found warm restart of orchagent is not supported on VOQ type chassis. How did you do it? For VOQ type chassis, uses "systemctl restart swss@0(1)" instead. How did you verify/test it? After the fix the test passed consistently against VOQ type chassis.
11 tasks
Author
|
@microsoft-github-policy-service agree [company="NOKIA"] |
Author
|
@microsoft-github-policy-service agree |
Author
|
@microsoft-github-policy-service agree company="NOKIA" |
|
@arlakshm need to merge this into 202503 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
test_lldp_neighbor_post_orchagent_reboot uses prefix restart_orchagent() to warm restart orchagent. This warm restart of orchagent(kill orchagent and restart orchagent process) is not supported on chassis with type VOQ.
Add code to handle chassis type VOQ case by restarting the swss@0(1) service. This will cause ports to be removed from lldp table and add back in so we can test the issue found in #6560.
Summary:
Fixes # (issue)
Type of change
Bug fix
Testbed and Framework(new/improvement)
New Test case
Skipped for non-supported platforms
Test case improvement
Back port request
202012
202205
202305
202311
202405
202411
Approach
What is the motivation for this PR?
Currently test_lldp_neighbor_post_orchagent_reboot is failing against chassis with type VOQ. It's found warm restart of orchagent is not supported on VOQ type chassis.
How did you do it?
For VOQ type chassis, uses "systemctl restart swss@0(1)" instead.
How did you verify/test it?
After the fix the test passed consistently against VOQ type chassis.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation